-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support fo "Renhållningen Kristianstad" in Kristianstad, Sweden #2741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you name the source krab_se? We typically name the source after the website ULR so renhallningen_kristianstad_se
here.
Did you do any testing before submitting this? The source is fundamentally broken at multiple points. Please test your source using the test script (test_sources.py) before submitting a PR
custom_components/waste_collection_schedule/waste_collection_schedule/source/krab_se.py
Outdated
Show resolved
Hide resolved
custom_components/waste_collection_schedule/waste_collection_schedule/source/krab_se.py
Outdated
Show resolved
Hide resolved
custom_components/waste_collection_schedule/waste_collection_schedule/source/krab_se.py
Outdated
Show resolved
Hide resolved
custom_components/waste_collection_schedule/waste_collection_schedule/source/krab_se.py
Outdated
Show resolved
Hide resolved
First of all naming conventions and naming. I'm sorry for the code as it's really so many things that's wrong there. There's no other way of sayng it than it's totally FU. |
Thanks for your contribution |
Added support for "Renhållningen Kristianstad" in Sweden to HACS waste collection service